chore: update ids#814
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the default client order ID prefixes used by the v2 spot and futures order services, and aligns the related request assertions in tests.
Changes:
- Updated spot client order ID prefix to
x-TKT5PX2F. - Updated futures/contract client order ID prefix to
x-cvBPrNm9. - Adjusted spot and futures order service tests to expect the new prefixes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| v2/order_service_test.go | Updates the expected spot newClientOrderId prefix in the request assertion. |
| v2/futures/order_service_test.go | Updates the expected futures newClientOrderId prefix in the request assertion. |
| v2/common/helpers.go | Updates the shared spot/contract order ID prefix constants used for ID generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| s.assertReq(func(r *request) { | ||
| s.Assertions.True(strings.HasPrefix(r.form.Get("newClientOrderId"), "x-B3AUXNYV")) | ||
| s.Assertions.True(strings.HasPrefix(r.form.Get("newClientOrderId"), "x-TKT5PX2F")) |
| closePosition := false | ||
| s.assertReq(func(r *request) { | ||
| s.Assertions.True(strings.HasPrefix(r.form.Get("newClientOrderId"), "x-ftGmvgAN")) | ||
| s.Assertions.True(strings.HasPrefix(r.form.Get("newClientOrderId"), "x-cvBPrNm9")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.