Skip to content

tests fixes - #16200

Open
AbhishekKumar9984 wants to merge 2 commits into
cdapio:cs_guava_upgradefrom
cloudsufi:cloudsufi-test-fix-guava
Open

tests fixes#16200
AbhishekKumar9984 wants to merge 2 commits into
cdapio:cs_guava_upgradefrom
cloudsufi:cloudsufi-test-fix-guava

Conversation

@AbhishekKumar9984

Copy link
Copy Markdown

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a duplicate application deployment bypass strategy (using AppDeployStrategy), propagates LoggingContext to worker threads in WorkflowDriver, and adds safety checks to service startup and shutdown sequences across several components to prevent state-related errors. The review feedback highlights critical issues, including a potential classloader deadlock in MapReduceClassLoader when starting a service inside a synchronized block, resource leak risks during shutdown in AppFabricProcessorService and test classes due to overly restrictive state checks, a potential NullPointerException in ApplicationLifecycleService when artifact versions are null, and a recommendation to use monotonic time (System.nanoTime()) in RemoteExecutionTwillController.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant