tests fixes - #16200
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a duplicate application deployment bypass strategy (using AppDeployStrategy), propagates LoggingContext to worker threads in WorkflowDriver, and adds safety checks to service startup and shutdown sequences across several components to prevent state-related errors. The review feedback highlights critical issues, including a potential classloader deadlock in MapReduceClassLoader when starting a service inside a synchronized block, resource leak risks during shutdown in AppFabricProcessorService and test classes due to overly restrictive state checks, a potential NullPointerException in ApplicationLifecycleService when artifact versions are null, and a recommendation to use monotonic time (System.nanoTime()) in RemoteExecutionTwillController.
No description provided.