Skip to content

Add feature.wrangler.jexl.allowlist.enabled flag for JEXL expressions allowlisting feature in Wrangler directives - #16202

Open
riyaa14 wants to merge 1 commit into
developfrom
add-secure-jexl-feature-flag
Open

Add feature.wrangler.jexl.allowlist.enabled flag for JEXL expressions allowlisting feature in Wrangler directives#16202
riyaa14 wants to merge 1 commit into
developfrom
add-secure-jexl-feature-flag

Conversation

@riyaa14

@riyaa14 riyaa14 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

This change introduces a feature flag to control enabling of a secure by default model for JEXL scripts in wrangler directives.

@riyaa14
riyaa14 requested a review from sahusanket August 14, 2026 13:41
@riyaa14 riyaa14 changed the title Add feature.wrangler.secure.jexl.enabled feature flag for secure JEXL in Wrangler directives Add feature.wrangler.secure.jexl.enabled flag for secure JEXL feature in Wrangler directives Aug 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new feature flag, WRANGLER_SECURE_JEXL, to enforce a secure-by-default model for JEXL scripts in Wrangler. A configuration mismatch was identified in cdap-default.xml where the property name feature.wrangler.secure.jexl.enabled was used instead of the expected feature.wrangler.secure.jexl mapping.

Comment thread cdap-common/src/main/resources/cdap-default.xml Outdated
@riyaa14
riyaa14 requested a review from vsethi09 August 17, 2026 08:13
</property>

<property>
<name>feature.wrangler.secure.jexl.enabled</name>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature.wrangler.jexl.allowlist.enabled

SOURCE_CONTROL_MANAGEMENT_GITLAB_BITBUCKET("6.10.1"),
DATAPLANE_AUDIT_LOGGING("6.10.1");
DATAPLANE_AUDIT_LOGGING("6.10.1"),
WRANGLER_SECURE_JEXL("6.12.0", false);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WRANGLER_JEXL_ALLOWLIST

@riyaa14
riyaa14 force-pushed the add-secure-jexl-feature-flag branch from 830db59 to 8d33fd2 Compare August 28, 2026 05:37
@riyaa14 riyaa14 changed the title Add feature.wrangler.secure.jexl.enabled flag for secure JEXL feature in Wrangler directives Add feature.wrangler.jexl.allowlist.enabled flag for secure JEXL feature in Wrangler directives Aug 28, 2026
@riyaa14 riyaa14 changed the title Add feature.wrangler.jexl.allowlist.enabled flag for secure JEXL feature in Wrangler directives Add feature.wrangler.jexl.allowlist.enabled flag for JEXL expressions allowlisting feature in Wrangler directives Aug 28, 2026
@riyaa14
riyaa14 force-pushed the add-secure-jexl-feature-flag branch from 8d33fd2 to b04fca1 Compare August 28, 2026 05:44
@riyaa14
riyaa14 removed the request for review from sahusanket August 28, 2026 05:46
@riyaa14 riyaa14 added the build Triggers github actions build label Aug 28, 2026
@riyaa14
riyaa14 force-pushed the add-secure-jexl-feature-flag branch from b04fca1 to 747d984 Compare August 28, 2026 08:41
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Triggers github actions build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants