[cherry-pick][6.10][CDAP-21269] Add support for Dataproc Flexible Machine Types in compute profiles

[123-komal]

Original PR: #16204

[gemini-code-assist]

Code Review

This pull request introduces a comprehensive error classification framework, including new error categories, types, and utility classes, while refactoring program lifecycle, runtime, and scheduling handlers. It also replaces the run record monitor with a new flow control service, enhances preview runner security, and adds support for skipping duplicate application deployments. Feedback on these changes highlights several areas for improvement: in ErrorCategory, redundant null checks on the final errorCategory field should be removed and block comments converted to Javadoc; in ErrorUtils, magic numbers for HTTP status codes should be replaced with named constants and a Javadoc typo corrected; in FailureDetailsProvider, the Javadoc return type for getErrorCategory needs correction; and in OperationHttpHandler, the regex for parsing filter key-value pairs should be made more flexible.

[gemini-code-assist]

The regex ("?)(\w+)=(\w+)("?) used for parsing filter key-value pairs is quite restrictive as \w+ only matches alphanumeric characters and underscores. This might be too limiting if filter values need to support other characters in the future (e.g., hyphens). Consider using a more flexible regex to make the filter more robust, for example by using [^=]+ for the value part.

[gemini-code-assist]

This comment block uses /* ... */ which is a block comment. For Javadoc, it should be /** ... */. This also applies to the comment for toString() on line 78.

Suggested change

	/*
	* Returns the category of the error.
	*/
	/**
	* Returns the category of the error.
	*/

[gemini-code-assist]

The Javadoc for getErrorCategory states that it returns a String, but the method signature indicates it returns an ErrorCategory object. The Javadoc should be corrected to reflect the actual return type.

Suggested change

	* @return a {@String} representing the error category.
	* @return an {@link ErrorCategory} representing the error category.

[gemini-code-assist]

The switch statement uses several magic numbers for HTTP status codes (e.g., 429, 416, 417). It's a best practice to define these as named constants to improve readability and maintainability. While some of these might not be in HttpURLConnection, they could be defined as private static final fields within this class.

[gemini-code-assist]

There is a typo in the Javadoc. It should be 'an ActionErrorPair' instead of 'A ActionErrorPair'.

Suggested change

	* @return A ActionErrorPair object with corrective action and error type.
	* @return an ActionErrorPair object with corrective action and error type.

[gemini-code-assist]

The errorCategory field is final and initialized in all constructors with a non-null value. Therefore, the null check errorCategory == null is redundant and can be removed.

Suggested change

	public ErrorCategoryEnum getParentCategory() {
	return errorCategory == null ? ErrorCategoryEnum.OTHERS : errorCategory;
	}
	public ErrorCategoryEnum getParentCategory() {
	return errorCategory;
	}

[gemini-code-assist]

The errorCategory field is final and initialized in all constructors with a non-null value. Therefore, the null check errorCategory == null is redundant and can be removed to simplify the code.

Suggested change

	public String getErrorCategory() {
	return errorCategory == null ? ErrorCategoryEnum.OTHERS.toString() : subCategory == null
	? errorCategory.toString() : String.format("%s-'%s'", errorCategory, subCategory);
	}
	public String getErrorCategory() {
	if (subCategory == null) {
	return errorCategory.toString();
	}
	return String.format("%s-'%s'", errorCategory, subCategory);
	}