fix(windows): chrome process idle no rendering - #781
Open
andrinoff wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
We stopped relying on Chrome announcing itself. Instead, VHS now starts Chrome on a port it picked itself and simply checks that port directly until Chrome answers. If Chrome never shows up, VHS gives up after 30 seconds with a clear error message instead of hanging forever.
Why?
VHS would freeze forever on Windows when running a tape — no output, no GIF, just Chrome processes sitting idle in the background. Nothing timed out, nothing errored; users had to force-kill it.
Closes #754