Add regression test for enter animation with fractional container width#12270
Open
zizhao-hu wants to merge 1 commit into
Open
Add regression test for enter animation with fractional container width#12270zizhao-hu wants to merge 1 commit into
zizhao-hu wants to merge 1 commit into
Conversation
chartjs#12256 reported that the enter animation is suppressed when a chart's container has a sub-integer CSS pixel width (e.g. CSS grid `fr` units, percentage widths or `calc()`). The underlying bug was already fixed on master by chartjs#12142 (Use integer canvas dimensions); this adds a dedicated regression test so the scenario can't silently regress. Closes chartjs#12256 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12256: the initial enter animation was suppressed when the chart container had a sub-integer CSS pixel width (CSS grid
frunits, percentage widths,calc()).The underlying bug is already fixed on
masterby #12142 (Use integer canvas dimensions), but nothing currently guards the scenario. This adds a focused regression test: a responsive line chart in a200.4pxcontainer, asserting the points start at the scale base (enter animation playing) rather than at their final value.Verified the test passes on
masterand fails on the pre-#12142 code.Closes #12256