Repository navigation
refactor!: stop saving legacy config values when configuring a transport - #8725
Merged
Merged
Conversation
link2xt
added this pull request to stack #8726
September 21, 2026 14:12
link2xt
force-pushed
the
link2xt/remove-save-legacy
branch
from
September 21, 2026 14:13
0f97f82 to
57b7629
Compare
link2xt
force-pushed
the
link2xt/json-rpc-no-account-addr
branch
from
September 21, 2026 14:13
0e49ade to
154e58a
Compare
link2xt
force-pushed
the
link2xt/remove-save-legacy
branch
from
September 21, 2026 14:20
57b7629 to
dd0f5a8
Compare
link2xt
force-pushed
the
link2xt/json-rpc-no-account-addr
branch
from
September 21, 2026 14:20
154e58a to
20b70ad
Compare
link2xt
force-pushed
the
link2xt/remove-save-legacy
branch
from
September 21, 2026 14:38
dd0f5a8 to
ba41c41
Compare
Collaborator
|
There is still a small amount of usages of the In order to enable updating, the commit message should likely have a footer "BREAKING CHANGE: Core does not update the already-deprecated |
Hocuri
approved these changes
Sep 21, 2026
link2xt
removed this pull request from stack #8726
September 21, 2026 14:58
link2xt
force-pushed
the
link2xt/remove-save-legacy
branch
3 times, most recently
from
September 21, 2026 18:48
7f17675 to
d84626f
Compare
link2xt
marked this pull request as ready for review
September 23, 2026 11:55
Users downgrading to UIs that load legacy config values is unlikely, and cannot work correctly with multiple transports. BREAKING CHANGE: core does not set deprecated config values `addr`, `mail_pw` etc. Use `list_transports()` API instead.
link2xt
force-pushed
the
link2xt/remove-save-legacy
branch
from
September 23, 2026 11:58
d84626f to
e145d38
Compare
link2xt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users downgrading to UIs that load legacy config values is unlikely,
and cannot work correctly with multiple transports.
BREAKING CHANGE: core does not set deprecated config values
addr,mail_pwetc. Uselist_transports()API instead.