Repository navigation
fix: In SMTP loop, reset transport_id and from when disconnecting - #8797
Merged
Merged
Conversation
Previously, when we disconnected from the current transport, we forgot to reset the `transport_id`. I couldn't find any bug that is caused by this today, but it was a lingering problem.
hpk42
approved these changes
Oct 2, 2026
link2xt
approved these changes
Oct 2, 2026
link2xt
left a comment
link2xt
left a comment
Collaborator
There was a problem hiding this comment.
If you want to reset everything, then self.from could be reset too, it is the address of the transport we are currently connected to.
Ideally from, transport_id and the connection itself should be all behind a single Option, current Smtp is just too stateful (has a lot of invalid states).
Hocuri
changed the title
transport_id and from when disconnecting
Hocuri
enabled auto-merge (squash)
October 2, 2026 18:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when we disconnected from the current transport, we forgot to reset the
transport_id. I couldn't find any bug that is caused by this today, but it was a lingering problem.