Skip to content

Add Scott Sader#48

Open
steviecoaster wants to merge 1 commit into
chocolatey:mainfrom
steviecoaster:scott
Open

Add Scott Sader#48
steviecoaster wants to merge 1 commit into
chocolatey:mainfrom
steviecoaster:scott

Conversation

@steviecoaster
Copy link
Copy Markdown
Contributor

Description Of Changes

Adds images of Scott or blog posts

Motivation and Context

Scott wrote a post, needs credited

Testing

Operating Systems Testing

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?
  • All items are complete on the Definition of Done.

Related Issue

@steviecoaster
Copy link
Copy Markdown
Contributor Author

@st3phhays I tried to do a 150x150 image using Image Resizer, which said it worked, but doesn't look right in preview here?

Copy link
Copy Markdown
Member

@st3phhays st3phhays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image needs to be 150px by 150px (square), or we need to change the file name to something like scott-sader-sm.jpg.

Comment thread people/scott.jpg
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the file name to scott-sader.jpg to include his last name?

@st3phhays
Copy link
Copy Markdown
Member

@st3phhays I tried to do a 150x150 image using Image Resizer, which said it worked, but doesn't look right in preview here?

You will need to crop the image into a square, not just resize it. Looks like that it made the width 150px, but kept the ratio for the height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants