Skip to content

add .github/ dir - #405

Merged
goto-bus-stop merged 1 commit into
masterfrom
github
Feb 13, 2018
Merged

add .github/ dir#405
goto-bus-stop merged 1 commit into
masterfrom
github

Conversation

@yoshuawuyts

Copy link
Copy Markdown
Member

Ran my local .github dir generator on the project. Includes issue & PR templates, CoC, stale.yml and a DOC. Lots of stuff in here, but hope it good. Thanks!

@goto-bus-stop

Copy link
Copy Markdown
Member

should we use the same CoC as choojs/choo#587 instead?

@yoshuawuyts

Copy link
Copy Markdown
Member Author

@goto-bus-stop was thinking the other CoC is a bit.. uncommon. This one's pretty well-understood, and basically says the same things.

@yoshuawuyts

Copy link
Copy Markdown
Member Author

Should probably raise that in the other issue too tho.

@cdaringe

cdaringe commented Feb 9, 2018

Copy link
Copy Markdown

no harm in eager merging and tidying later no? this is the good stuff!

@goto-bus-stop

Copy link
Copy Markdown
Member

i was waiting for choojs/choo to merge but i guess there's not really any reason to :P thanks!

@goto-bus-stop
goto-bus-stop merged commit 83c5108 into master Feb 13, 2018
@yoshuawuyts
yoshuawuyts deleted the github branch February 13, 2018 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants