Repository navigation
Conversation
…route Signed-off-by: matti.bat <138713607+mattibat@users.noreply.github.com>
…able Signed-off-by: matti.bat <138713607+mattibat@users.noreply.github.com>
dc00822 to
e729e3e
Compare
|
Please don't spam AI-generated PRs, this one is also just noise that shuffles code around for little to no gain.
The "problem" you described has literally zero impact, an intentionally crafted invalid authenticated request would cause a zero-impact reflected 500 error if the params exist but not string, and your code solves this bug, but it also introduces the exact same bug again for strings like And again, I do recognize that this file could be done better, but so can basically every file in this codebase. |
|
fair point. agreed the refactor wasn't worth the diff for what it fixed. Happy to send just the 2 line validation fix on its own if thats useful, otherwise no worries either way. |
Problem
Fix