Conversation
ckipp01
left a comment
ckipp01
left a comment
There was a problem hiding this comment.
Overall @oyvindberg I really like this diff. There are a couple small things that I pointed out, but overall I like it. One other thing I noticed is that something seems to be up with the highlightStyle on the selected item in the ListWidget as it's not working for me now. I need to try and dig in further to see why that's no longer working.
| title = Some(todoBorderTitle) | ||
| )( | ||
| ListWidget( | ||
| items = todoItems.map(item => toListItem(item, area.width)), |
There was a problem hiding this comment.
This is another interesting one @oyvindberg that maybe I'm just using the area.width when I should instead be using something else, but I want it to know how much space to put between the title the date for one to be left aligned and the other right aligned on the same line. In order to achieve that I need to know how wide the widget will be. So I can wrap it in a Widget, but idn, sort of stinks that I need to do that. Maybe it's fine, idn. Thinking about it, with the cursor example it'd be fine to get it after I put the layout together, but here it's sort of a chicken and the egg problem.
| frame.setCursor( | ||
| x = area.x + Grapheme(state.description).width + 1, | ||
| y = area.y + 1 | ||
| ) |
There was a problem hiding this comment.
So this is what I was referring to on the other PR, it's a but of a bummer since I only need to do this when I'm on the description and in input mode, but still need to wrap it in a Widget even when it's not that. It's not the worst, but yea.
1 participant
Trying out oyvindberg/jatatui#50.