Upgrade to Go 1.27 + buildx cross-compilation - #215
Open
terinjokes wants to merge 3 commits into
Open
Conversation
Also removes the setting of the deprecated "SetCAOnCertificateRequest", which will stop populating the "ca.crt" field in the Kubernetes Secret.
For a while now QEMU has emulated arm64 utilizing only a single core. This resulted in our linux/arm64 builds taking an extremely long time. Docker supports native cross-compilation with the special `$BUILDPLATFORM` and `$TARGETPLATFORM` build arguments. This allows us to cross-compile the controller on the fast native architecture, then copy the resulting binary onto an image layer of the target architecture.
Contributor
Author
|
The CodeQL failure was fixed upstream github/codeql@d24ab5e (github/codeql#22042), but not yet tagged in a release. |
cbroglie
reviewed
Aug 27, 2026
| Check: s.Check, | ||
| Sign: s.Sign, | ||
| EventRecorder: mgr.GetEventRecorder("originissuer." + v1.GroupVersion.Group), | ||
| SetCAOnCertificateRequest: true, |
There was a problem hiding this comment.
Is this going to be a user-facing behavior change? I know the field is deprecated, but it looks like it still exists in v0.12.0
Contributor
Author
There was a problem hiding this comment.
Yes, ca.crt would not be added on newer Secrets. I've had cert-manager/issuer-lib#204 open for a year and a half, and in that time have struggled to come up with software that cares.
cbroglie
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to Go 1.27 and modify Docker build to utilize buildx's native cross-compilation support.