STOR-5489: Measure Durable Object RPC replay memory - #7408
Open
apeacock1991 wants to merge 6 commits into
Open
apeacock1991 wants to merge 6 commits into
apeacock1991 wants to merge 6 commits into
Conversation
Actors built by TestFixture had no class, so any test that sent an actor request through the real entrypoint failed with "Failed to get handler to worker" before reaching user code. actorClassName names the exported Durable Object class to construct on the first request.
JsRpcSessionCustomEvent::run() now calls claimRetryTokenBeforeUserCode() before delivered(). A rejected claim is passed to failed() so the session capability carries the rejection details instead of a generic teardown disconnect. Failures after delivery carry the worker-delivered and actor-delivered details and drop the not-delivered marker. This covers method errors, session failures, and actor aborts on the revocation path.
A replayable call to a destination that supports actor call retries is dispatched through newActorCallAttempt() with a first-attempt token. Property reads, transient stubs, and calls with non-replayable arguments stay on the single-use path. The token has enforcement disabled, and there is no replay loop yet. Both ends are behind a new observe-only autogate, DURABLE_OBJECT_RETRIES_JSRPC, so JSRPC can roll out separately from the fully deployed fetch gates. A JSRPC retry-request gate will follow with sender replay. The gate-off sender tests initialize exactly the gates they name, with IgnoreAllAutogatesEnv::YES, so they hold under the all-autogates test variant. The receiver tests assert claim and delivery details on the native JsRpcTarget.call() result, and cover a rejected claim leaving the actor unconstructed, getter failures, and a native not-delivered disconnect that aborts the actor after the call was delivered.
RequestObserver::observeOutgoingActorRpcCall() returns an OutgoingActorCallObserver for one JsRpcTarget.call() attempt. The caller records success or failure from the call's own result. If the observer is dropped first, that means the attempt was canceled. ActorCallPayloadReplayable moves from actor-call-retry.h to observer.h so the hook and ActorCallRetryState use the same type. Nothing calls the hook yet.
Durable Object JS RPC calls were observed through their session promise, which settles with capability lifetime rather than call latency and does not describe the call payload. Observe each call result instead. The outgoing provider reports optional actor target retryability, distinguishing non-actor calls from retryable and non-retryable actor calls. Fetch uses the same classification, including colo-local actors and facets. Calls through pending actor result pipelines retain actor provenance but cannot create a fresh attempt independently. Tests cover this path, payload replayability, settlement ordering, cancellation, and target eligibility.
Track projected memory for replayable JSRPC calls without retaining another payload copy. Release accounting when the call settles, its caller context ends, or pipeline use commits it to the current attempt.
Contributor
|
LGTM |
apeacock1991
force-pushed
the
apeacock/jsrpc-call-observation
branch
from
September 18, 2026 16:35
29a7e8f to
4e2f751
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #7346.
Summary
IoOwnso access and destruction stay on the originatingIoContext.This change measures projected retention only. It does not enable sender replay.