Skip to content

Enable incoming Request.signal by default from 2026-11-17 #7798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
irvinebroque wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Enable incoming Request.signal by default from 2026-11-17 #7798

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2bef51f
Enable incoming Request.signal by default from 2026-11-01
irvinebroque Oct 17, 2026
a95ccdf
Delay incoming Request.signal default to 2026-11-08
irvinebroque Oct 23, 2026
92ce48b
Merge branch 'main' into codex/request-signal-default-nov-2026
irvinebroque Oct 23, 2026
f56b70b
Merge branch 'main' into codex/request-signal-default-nov-2026
irvinebroque Oct 30, 2026
86a2153
Delay incoming Request.signal default to 2026-11-12
irvinebroque Oct 30, 2026
d2bd987
Test the incoming Request.signal default boundary and overrides
irvinebroque Oct 30, 2026
3adbfe0
Move incoming Request.signal default to November 17
irvinebroque Oct 31, 2026
b5a6279
Merge branch 'main' into codex/request-signal-default-nov-2026
irvinebroque Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/workerd/io/compatibility-date-test.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,8 +590,7 @@ KJ_TEST("encode to full flag list") {
}

KJ_TEST("compatibility dates must be Tuesday, Wednesday, or Thursday") {
// List of specific flags that are allowed to use non-conformant dates
// (already deployed and can't be changed for compatibility reasons)
// Specific flags with compatibility dates outside the normal release weekdays.
kj::HashSet<kj::StringPtr> allowedFlagExceptions;
allowedFlagExceptions.insertAll(std::initializer_list<kj::StringPtr>{
// Existing non-conformant dates that are already deployed
Expand Down Expand Up @@ -632,6 +631,9 @@ KJ_TEST("compatibility dates must be Tuesday, Wednesday, or Thursday") {
"stripAuthorizationOnCrossOriginRedirect"_kj, // 2025-09-01 (Monday)
"enableCtxExports"_kj, // 2025-11-17 (Monday)

// Scheduled default enablement on November 8, 2026 (Sunday).
"enableRequestSignal"_kj,

// Non-conformant dates via impliedByAfterDate
"pythonWorkers"_kj, // 2000-01-01 (Saturday) via impliedByAfterDate
"nodeJsCompatV2"_kj, // 2024-09-23 (Monday) via impliedByAfterDate
Expand Down
4 changes: 2 additions & 2 deletions src/workerd/io/compatibility-date.capnp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Copyright (c) 2017-2022 Cloudflare, Inc.
# Licensed under the Apache 2.0 license found in the LICENSE file or at:
# https://opensource.org/licenses/Apache-2.0
Expand Down Expand Up @@ -793,9 +793,9 @@

enableRequestSignal @90 :Bool
$compatEnableFlag("enable_request_signal")
$compatDisableFlag("disable_request_signal");
$compatDisableFlag("disable_request_signal")
$compatEnableDate("2026-11-08");

@ask-bonk ask-bonk Bot Oct 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[WARNING] The updated test only exempts this field from the weekday check; it never compiles a date on either side of 2026-11-08. Deleting or changing this annotation, or breaking the disable_request_signal override, would therefore pass the suite while removing the announced default. Add a boundary assertion to KJ_TEST("encode to full flag list") in compatibility-date-test.c++:

Suggested change
$compatEnableDate("2026-11-08");
{
constexpr auto flag = "enable_request_signal"_kj;
KJ_EXPECT(!contains(
decompileCompatibilityFlags(compileOwnFeatureFlags("2026-11-07", {}).get()), flag));
KJ_EXPECT(contains(
decompileCompatibilityFlags(compileOwnFeatureFlags("2026-11-08", {}).get()), flag));
KJ_EXPECT(!contains(decompileCompatibilityFlags(compileOwnFeatureFlags(
"2026-11-08", {"disable_request_signal"_kj})
.get()),
flag));
}

# Enables Request.signal for incoming requests.
# This feature is still experimental and the compat flag has no default enable date.

connectPassThrough @91 :Bool
$compatEnableFlag("connect_pass_through")
Expand Down
Loading