Skip to content

Add python_zstd_snapshot compat flag - #8021

Open
ryanking13 wants to merge 1 commit into
mainfrom
gyeongjae/zstd-writer
Open

ryanking13 wants to merge 1 commit into
mainfrom
gyeongjae/zstd-writer

Conversation

@ryanking13

@ryanking13 ryanking13 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Adds a compat flag that will be used to test the zstd compression for Python workers. The implementation will be done in the internal repo.

@ryanking13
ryanking13 requested review from a team as code owners October 27, 2026 07:34
@clanky-the-clanker

clanky-the-clanker Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

✅ Approved — Single additive, experimental compat flag with a correct ordinal and a unique name, and no issues found.

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The new flag pythonZstdSnapshot @199 takes the next free ordinal. Its flag name is unique. It is marked $experimental and has no enable date, so it can't be enabled by default.


Reviewed commit: 21f9d61c

@ask-bonk

ask-bonk Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Since last review: 0 resolved, 0 still open, 0 new.
LGTM!


Reviewed commit: 21f9d61c · github run

@ryanking13
ryanking13 force-pushed the gyeongjae/zstd-writer branch from 1f54e1f to 21f9d61 Compare October 27, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants