Repository navigation
Conversation
Also guard the source-switcher listener against an undefined source (the customer's "reading 'videoSources'" TypeError) and note the follow-up on currentSourceType() throwing after the plugin state is reset.
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsi
force-pushed
the
fix/hevc-h264-fallback
branch
from
October 1, 2026 08:45
1cc746c to
f8d8783
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #1093. Adds a repro page for ONCALL-11435 and two small defensive changes that are not required for the fix itself. Kept separate so the fix PR stays minimal; this one may not be merged.
Changes
docs/hevc-fallback.html: repro page for the HEVC → H264 fallback.?simulateNoHevc=truestubscanPlayType/MediaSource.isTypeSupported/addSourceBufferto report no HEVC support so the fallback can be exercised on any browser;&ver=4.1.2loads a published build for comparison;&types=hls/h264is the control. Not linked from the examples index.cldsourcechangedlistener against an undefined source (source?.videoSources?.()). This was the customer'sTypeError: Cannot read properties of undefined (reading 'videoSources'). With fix: don't undo Video.js source fallback on media error #1093 the TypeError no longer occurs in the reported scenario, so this is defensive only.currentSourceType(), which throws once the plugin state has been reset bysyncState.Related
How to Test
Run the dev server and open
hevc-fallback.html?simulateNoHevc=true. Expected on top of #1093: h265 errors once, h264 plays, snapshot at 10s showserror=null. With&ver=4.1.2: h265 is reloaded, thevideoSourcesTypeError is logged, playback never starts.