Skip to content

No echo when running command from Crsh #53

Description

@nyh

Crsh switches the terminal to raw mode (not exactly, but close enough) when reading the command line, so it gets the input after each character, and does it own echo.
However, just before we run a command, we need to switch back to cooked mode, so that the command we run can behave as Unix programs expect, to be run in cooked mode (and get echo and a line discipline).

I remember we got this working correctly, but apparently it longer is.
If you run

$ make image=memcached.none,mgmt.full
$ scripts/run.py
[/]% run memcached.so -u root

You see memcached.so runs without echo enabled (if you type anything, you don't see what you type). OSv is not hung at this point, it's just not echoing characters.

To see that echo is working outside crsh, run the same memcached directly without crsh:

$ make image=memcached
$ scripts/run.py

and see how the input characters are echoed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions