Skip to content

chore(greenhouse): make admin area toolbar consistent across tabs#1767

Open
guoda-puidokaite wants to merge 5 commits into
mainfrom
guoda-gh-admin-toolbar-consistency
Open

chore(greenhouse): make admin area toolbar consistent across tabs#1767
guoda-puidokaite wants to merge 5 commits into
mainfrom
guoda-gh-admin-toolbar-consistency

Conversation

@guoda-puidokaite

@guoda-puidokaite guoda-puidokaite commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixed DataGridToolbar inconsistencies in Admin Area across all tabs.

See ticket.

Changes Made

  • "Clear all" button placed near selected filter pills
  • Text "(X ready, X not ready)" and "Last updated: ..." gray colour
  • DataGridToolbar component always used to ensure alignment
Screenshot 2026-06-16 at 14 53 21 Screenshot 2026-06-16 at 14 53 14 Screenshot 2026-06-16 at 14 53 08

Related Issues

Closes #1766

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

Signed-off-by: I531348 <guoda.puidokaite@sap.com>
Signed-off-by: I531348 <guoda.puidokaite@sap.com>
@guoda-puidokaite guoda-puidokaite self-assigned this Jun 16, 2026
Copilot AI review requested due to automatic review settings June 16, 2026 12:44
@guoda-puidokaite guoda-puidokaite requested a review from a team as a code owner June 16, 2026 12:44
@guoda-puidokaite guoda-puidokaite added greenhouse Greenhouse core related task greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` labels Jun 16, 2026
@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d02e66f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR targets the Greenhouse Admin Area DataGrid header/tooling UI to make the toolbar layout and styling consistent across the PluginPresets, Clusters, and Exposed Services tabs.

Changes:

  • Moved the “Clear all” action next to the selected filter pills in PluginPresets.
  • Applied consistent “light/gray” text styling for status/metadata lines in the toolbar area.
  • Ensured the Clusters tab also wraps its toolbar content in DataGridToolbar for consistent structure/alignment.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
apps/greenhouse/src/components/admin/PluginPresets/PluginPresetsFilters.tsx Repositions “Clear all” alongside selected filter pills to match other tabs.
apps/greenhouse/src/components/admin/PluginPresets/index.tsx Updates toolbar styling within DataGridToolbar for consistent appearance.
apps/greenhouse/src/components/admin/ExposedServices/index.tsx Updates toolbar styling within DataGridToolbar for consistent appearance.
apps/greenhouse/src/components/admin/Clusters/index.tsx Wraps toolbar content in DataGridToolbar to align structure with other tabs.

Comment thread apps/greenhouse/src/components/admin/PluginPresets/index.tsx Outdated
Comment thread apps/greenhouse/src/components/admin/ExposedServices/index.tsx Outdated
Comment thread apps/greenhouse/src/components/admin/Clusters/index.tsx Outdated
Signed-off-by: I531348 <guoda.puidokaite@sap.com>
@github-actions github-actions Bot added the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Jun 16, 2026
Signed-off-by: I531348 <guoda.puidokaite@sap.com>
@github-actions github-actions Bot added greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. and removed greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. labels Jun 17, 2026
@github-actions github-actions Bot removed the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Jun 17, 2026
@github-actions github-actions Bot added the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenhouse Greenhouse core related task greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task](greenhouse): Make DataGridToolbar consistent in Admin Area

3 participants