Bug fixed for ceph RGW diff fix - #248
Open
sarwottamdev wants to merge 1 commit into
Open
Conversation
sarwottamdev
requested review from
aiivashchenko,
arttor,
fa-at-pulsit and
schucly
as code owners
August 7, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff Fix for Ceph RGW
Description
This PR addresses issues identified during diff migrations against Ceph RGW and fixes cases where valid copy operations were not executed.
1. Object Key Normalization Fix
Updated the
normalizeOutputNameandnormalizeInputNamefunctions to stop prepending a leading/to object keys.Previously, object keys for non-MinIO providers (such as Ceph RGW) were normalized with a leading slash, causing S3 operations including:
StatObjectGetObjectPutObjectto fail with errors such as:
Object keys are now preserved as-is, ensuring compatibility with Ceph RGW object lookups.
2. Diff Pipeline Fix
File:
service/worker/handler/diff_handlers.goChanges:
len(objectsToRemove) == 0early return fromEnsureObjectsDeleted()fixCopySetStore.Drop()to clean up stale Redis state before creating new diff-fix copy tasksThis prevents scenarios where the diff-fix workflow exits prematurely and skips required copy operations.
3. Diff Fix Copy Version Check Bypass
File:
service/worker/handler/migration_obj_copy_handler.goAdded an
isDiffFixcheck to bypass the version validation below for diff-fix copy tasks:This prevents valid diff-fix copy operations from being skipped due to version comparison logic that is intended for normal migration workflows rather than repair or reconciliation tasks.
Checklist
Signed-off-byline to certify agreement with the pdated documentation in README.md if applicable.Note: By submitting this PR, you agree to license your contributions under the Apache 2.0 License _CONDUCT.md.