Save the toy-by-toy fit error on tracked parameters #471
Open
emanueledimarco wants to merge 11 commits into
Open
Save the toy-by-toy fit error on tracked parameters #471emanueledimarco wants to merge 11 commits into
emanueledimarco wants to merge 11 commits into
Conversation
Contributor
Author
|
@nucleosynthesis also finally added the saving of covQual to the tree |
Contributor
|
@emanueledimarco What is done in this case when there is no uncertainty associated to the parameter being tracked (it could be constant for example)? |
Contributor
Author
|
@nucleosynthesis I didn't checked yet what happens. Let me do it and in case something breaks update it. |
Contributor
|
hey @emanueledimarco any update with the checking for the no associated uncertainty case? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For each tracked parameters, it saves the fitted uncertainty as "trackedParamErr_"
(the central value is saved as "trackedParam_").
This is useful to make pulls not just using a single pre-fit uncertainty.
Sorry for the many commits, but the only one really doing something is e89de0e.
The others can be squashed if you want.
@mdunser, @cippy also using this.