Skip to content

Fix needed for change in root io protocol root-project/root#22744#51432

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
smuzaffar:fix-root-io-protocol
Jul 8, 2026
Merged

Fix needed for change in root io protocol root-project/root#22744#51432
cmsbuild merged 1 commit into
cms-sw:masterfrom
smuzaffar:fix-root-io-protocol

Conversation

@smuzaffar

@smuzaffar smuzaffar commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

This change is needed to make sure cmssw still uses its TFileAdaptor ( see cms-sw/cmsdist#10706 (comment) failure after root-project/root#22744 change in ROOT master and ROOT 6.40). Root's now register TNetXNGFile for ^[x]?root[s]?: protocol which override cmssw's TStorageFactoryFile to hanle ^root: or ^[x]?root:. This PR proposes that before adding CMSSW handlers we make sure to delete any handlers register by ROOT itself.

FYI @Dr15Jones

@cmsbuild cmsbuild added this to the CMSSW_20_1_X milestone Jul 7, 2026
@cmsbuild

cmsbuild commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@smuzaffar smuzaffar force-pushed the fix-root-io-protocol branch from d85daea to 06d2904 Compare July 7, 2026 09:59
@cmsbuild

cmsbuild commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51432/50102

@cmsbuild

cmsbuild commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • FWStorage/TFileAdaptor (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar

smuzaffar commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@jblomer , can you please confirm if this is the correct fix to make sure CMSSW uses its plugin for access root: files?

@smuzaffar

smuzaffar commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

please test

This was referenced Jul 7, 2026
Merged
Merged
@cmsbuild

cmsbuild commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94fc31/54558/summary.html
COMMIT: 06d2904
CMSSW: CMSSW_20_1_X_2026-07-06-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51432/54558/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3547841
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3547817
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar mentioned this pull request Jul 7, 2026
Open
@jblomer

jblomer commented Jul 7, 2026

Copy link
Copy Markdown

@jblomer , can you please confirm if this is the correct fix to make sure CMSSW uses its plugin for access root: files?

Looks good to me. Apologies for the trouble!

@smuzaffar

smuzaffar commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

In my current change, I think there is no need to explicitly remove the handler . Adding a handler with same regex override it, I am testing it locally and will update the PR

@smuzaffar smuzaffar force-pushed the fix-root-io-protocol branch from 06d2904 to 47227b7 Compare July 7, 2026 13:14
@cmsbuild

cmsbuild commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51432/50108

@cmsbuild

cmsbuild commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Pull request #51432 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

@smuzaffar smuzaffar force-pushed the fix-root-io-protocol branch from b3b2220 to 1c8dfff Compare July 7, 2026 17:31
@cmsbuild

cmsbuild commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51432/50114

@smuzaffar

smuzaffar commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

cmsbuild commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Pull request #51432 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

@Dr15Jones

Dr15Jones commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

+1

assuming the tests will pass

@cmsbuild

cmsbuild commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild

cmsbuild commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94fc31/54576/summary.html
COMMIT: 1c8dfff
CMSSW: CMSSW_20_1_X_2026-07-07-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51432/54576/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3547841
  • DQMHistoTests: Total failures: 43
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3547780
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@smuzaffar

smuzaffar commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@cms-sw/orp-l2 , feel free to merge it for next IB

@mandrenguyen

mandrenguyen commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 87732de into cms-sw:master Jul 8, 2026
10 checks passed
@cmsbuild cmsbuild mentioned this pull request Jul 8, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Dr15Jones Dr15Jones Dr15Jones requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-checks-approved core-approved fully-signed orp-approved tests-approved

Projects

None yet

Milestone

CMSSW_20_1_X

Development

Successfully merging this pull request may close these issues.

5 participants

@smuzaffar @cmsbuild @jblomer @Dr15Jones @mandrenguyen