specs-go: remove x/mod semver dependency - #333
Draft
thaJeztah wants to merge 3 commits into
Draft
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
CDI spec versions are a small, fixed set, so using `golang.org/x/mod/semver` just to compare them is unnecessary. Keep the versions in order instead and use that ordering for validation and minimum-version checks. This also keeps support for versions with or without a leading `v`. As a side effect, `ValidateVersion` gets noticeably faster for valid versions in local benchmarks, with no change in allocations. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
specs-go: remove x/mod semver dependency
CDI spec versions are a small, fixed set, so using
golang.org/x/mod/semverjust to compare them is unnecessary.Keep the versions in order instead and use that ordering for validation and
minimum-version checks. This also keeps support for versions with or without a
leading
v.As a side effect,
ValidateVersiongets noticeably faster for valid versionsin local benchmarks, with no change in allocations.
I wrote a quick benchmark, but probably not worth to keep (so I can drop that commit);