fix(ci): repair checks broken by #2374 - #2377
Merged
Merged
Conversation
#2374 landed as a critical fix while its CI was red. Two checks fail on main because of it: - `end-of-file-fixer` (Fast Check, Build & Test): the new `python/tests/connectorkits/__init__.py` holds a lone newline; the sibling test packages are all empty files. Truncate it. - `mypy` (E2E Type Check): the regression test calls `async_iter.aclose()`, but `sync_to_async_iter` declares `-> AsyncIterator[_T]`, which has no `aclose`. It is an async generator, and its whole point post-#2374 is that closing it does not block the event loop, so declare `-> AsyncGenerator[_T, None]` — the honest, more specific type. `AsyncGenerator` is a subtype of `AsyncIterator`, so no caller changes. The Windows build-test failure on the PR run was a `setup-uv` network flake, not a code problem. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#2374 was merged as a critical fix while its CI was red, leaving
mainfailing on Fast Check, E2E Type Check, and Build & Test. Two real errors, both from that commit:end-of-file-fixer(Fast Check + Build & Test): the newpython/tests/connectorkits/__init__.pyholds a lone newline. Every sibling test package (python/tests/connectors/,core/,resources/) is a 0-byte file. Truncated to match.mypy(E2E Type Check):python/tests/connectorkits/test_async_adapters.py:32: error: "AsyncIterator[int]" has no attribute "aclose".sync_to_async_iteris an async generator but declares-> AsyncIterator[_T], which hidesaclose(). Since the entire point of that fix is that closing the iterator no longer blocks the event loop, the honest, more specific annotation is-> AsyncGenerator[_T, None].AsyncGeneratoris a subtype ofAsyncIterator, so the four existingasync forcall sites are unaffected.The Windows
build-testfailure on the PR run was unrelated infrastructure —setup-uvgotfetch failedpulling the uv version manifest; the remaining matrix legs were cancelled by fail-fast.Testing
prek run --all-files mypy-check— passes, both against the default dev deps and against the E2E job'suv sync --no-dev --group ciset (the two dependency sets differ; verified separately).PREK_SKIP=<fast-check skip list> prek run --all-files— all hooks pass,fix end of filesincluded.uv run pytest python/tests/connectorkits/ -q— 1 passed.Note, out of scope
uv.lockis stale relative topyproject.toml: #2359 addedpymysqlandaiohttpto theci-enabled-optional-depsgroup without relocking, and theuv-lockhook is file-filtered so it never fired. Any localuv runrewrites the lock. Harmless in CI today (the sync steps are not--locked), and deliberately left out of this PR to keep the diff scoped to the fallout.🤖 Generated with Claude Code