Skip to content

Fix: Ask (Gemini) panel placement with Comments in Sidebar enabled #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ishaan488 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Ask (Gemini) panel placement with Comments in Sidebar enabled #4214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions js&css/web-accessible/www.youtube.com/appearance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ ImprovedTube.commentsSidebar = function () { if (ImprovedTube.storage.comments_s
state.hasApplied = 2
}
else { /// <1000
restoreAskPanel();
if (state.hasApplied == 1) {
moveNode(document.getElementById("primary-inner"), document.getElementById("related"));
let comments = document.querySelector("#comments");
Expand Down Expand Up @@ -317,20 +318,43 @@ ImprovedTube.commentsSidebar = function () { if (ImprovedTube.storage.comments_s
moveNode(primaryInner, document.getElementById("related"))
moveNode(secondaryInner, document.getElementById("chat-template"));
moveNode(secondaryInner, comments);
placeAskPanel(secondaryInner, comments);
})
}
function moveNode (parent, child) {
if (parent && child && child.parentElement !== parent) {
parent.appendChild(child);
}
}
function placeAskPanel(secondaryInner, comments) {
const askPanel = document.querySelector('ytd-engagement-panel-section-list-renderer[target-id="PAyouchat"]');
if (!askPanel || !secondaryInner) return;
if (comments && comments.parentElement === secondaryInner) {
secondaryInner.insertBefore(askPanel, comments);
} else if (askPanel.parentElement !== secondaryInner) {
secondaryInner.appendChild(askPanel);
}
}
function restoreAskPanel() {
const askPanel = document.querySelector('ytd-engagement-panel-section-list-renderer[target-id="PAyouchat"]');
const panels = document.getElementById("panels");
if (askPanel && panels && askPanel.parentElement !== panels) {
panels.appendChild(askPanel);
}
}
function isLayoutApplied (wideLayout) {
const secondaryInner = document.getElementById("secondary-inner");
const comments = document.querySelector("#comments");
const related = document.getElementById("related");
const relatedParent = wideLayout ? document.getElementById("columns") : document.getElementById("primary-inner");

return comments && comments.parentElement === secondaryInner && related && related.parentElement === relatedParent;
const askPanel = document.querySelector('ytd-engagement-panel-section-list-renderer[target-id="PAyouchat"]');

const askPanelOk = !askPanel || (
askPanel.parentElement === secondaryInner &&
(!comments || comments.parentElement !== secondaryInner ||
!!(askPanel.compareDocumentPosition(comments) & Node.DOCUMENT_POSITION_FOLLOWING))
);
return comments && comments.parentElement === secondaryInner && related && related.parentElement === relatedParent && askPanelOk;
}
function scheduleSidebar () {
clearTimeout(state.sidebarRetryTimer);
Expand Down