fix: validate sponsor seats and number_of_coaches presence

app/models/sponsor.rb

@@ -32,6 +32,8 @@ class Sponsor < ApplicationRecord
 
   validates :level, inclusion: { in: Sponsor.levels.keys }
   validates :name, :address, :avatar, :website, :level, presence: true
+  validates :number_of_coaches, presence: true, numericality: { greater_than_or_equal_to: 0, only_integer: true }
+  validates :seats, presence: true, numericality: { greater_than_or_equal_to: 0, only_integer: true }
   validate :website_is_url, if: :website?
 
   default_scope -> { order('updated_at desc') }

app/views/admin/sponsors/_form.html.haml

@@ -1,4 +1,4 @@
-= simple_form_for [:admin, @sponsor], :html => {:multipart => true, novalidate: true } do |f|
+= simple_form_for [:admin, @sponsor], html: { multipart: true, novalidate: false } do |f|
   .row
     .col-12.col-md-6
       = f.input :name
@@ -27,9 +27,9 @@
           %p Only required for hosts.
           .row
             .col-6
-              = f.input :seats
+              = f.input :seats, input_html: { required: true, min: 0 }
             .col-6
-              = f.input :number_of_coaches
+              = f.input :number_of_coaches, input_html: { required: true, min: 0 }
           = f.input :accessibility_info, input_html: { rows: 3 },
             hint: raw(t('admin.shared.markdown_hint', link: link_to(t('admin.shared.markdown'), 'https://commonmark.org/help/')))
           %p

spec/controllers/admin/sponsors_controller_spec.rb

@@ -39,7 +39,7 @@
         expect do
           post :create, params: {
             sponsor: {
-              name: 'name', website: 'https://example.com', seats: 40,
+              name: 'name', website: 'https://example.com', seats: 40, number_of_coaches: 10,
               address: address, avatar: avatar
             }
           }
@@ -53,7 +53,7 @@
         expect do
           post :create, params: {
             sponsor: {
-              name: 'name', website: 'https://example.com', seats: 40,
+              name: 'name', website: 'https://example.com', seats: 40, number_of_coaches: 10,
               address: address, avatar: avatar, contact_ids: [member.id, member1.id]
             }
           }
@@ -67,7 +67,7 @@
         expect do
           post :create, params: {
             sponsor: {
-              name: 'name', website: 'https://example.com', seats: 40,
+              name: 'name', website: 'https://example.com', seats: 40, number_of_coaches: 10,
               address: address, avatar: avatar, contact_ids: [member.id, member1.id]
             }
           }
@@ -81,7 +81,7 @@
         expect do
           post :create, params: {
             sponsor: {
-              name: 'name', website: 'https://example.com', seats: 40,
+              name: 'name', website: 'https://example.com', seats: 40, number_of_coaches: 10,
               address: Fabricate(:address, latitude: '54.47474', longitude: '-0.12345'),
               avatar: avatar, members: []
             }

spec/fabricators/sponsor_fabricator.rb

@@ -10,6 +10,8 @@
   website { "http://#{Faker::Internet.domain_name}" }
   avatar { Rack::Test::UploadedFile.new(Rails.root.join('app', 'assets', 'images', 'sponsors', sponsor_image), 'image/png') }
   address
+  seats { Faker::Number.between(from: 1, to: 50) }
+  number_of_coaches { Faker::Number.between(from: 1, to: 50) }
 end
 
 Fabricator(:sponsor_full, from: :sponsor) do

spec/features/admin/manage_sponsor_spec.rb

@@ -16,6 +16,7 @@
         fill_in 'Website', with: 'https://www.sponsorname.com/'
         attach_file('Avatar', Rails.root + 'spec/support/codebar-logo.png')
         fill_in 'Student spots', with: 20
+        fill_in 'Coach spots', with: 10
         select "Bronze", from: "Level"
 
         click_on 'Create sponsor'
@@ -32,6 +33,7 @@
         fill_in 'Website', with: 'https://www.sponsorname.com/'
         attach_file('Avatar', Rails.root + 'spec/support/codebar-logo.png')
         fill_in 'Student spots', with: 20
+        fill_in 'Coach spots', with: 10
 
         click_on 'Create sponsor'
 
@@ -47,6 +49,7 @@
         fill_in 'Website', with: 'https://www.sponsorname.com/'
         attach_file('Avatar', Rails.root + 'spec/support/codebar-logo.png')
         fill_in 'Student spots', with: 20
+        fill_in 'Coach spots', with: 10
 
         click_on 'Create sponsor'
 

spec/models/sponsor_spec.rb

@@ -7,6 +7,10 @@
     it { is_expected.to validate_presence_of(:avatar) }
     it { is_expected.to validate_presence_of(:website) }
     it { is_expected.to validate_presence_of(:level) }
+    it { is_expected.to validate_presence_of(:number_of_coaches) }
+    it { is_expected.to validate_presence_of(:seats) }
+    it { is_expected.to validate_numericality_of(:number_of_coaches).is_greater_than_or_equal_to(0).only_integer }
+    it { is_expected.to validate_numericality_of(:seats).is_greater_than_or_equal_to(0).only_integer }
 
     context 'scopes' do
       describe 'searching by_name' do