Skip to content

fix(Alert): honour explicit role={undefined} to suppress role attribute #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
revolunet merged 2 commits into from
May 27, 2026
Merged

fix(Alert): honour explicit role={undefined} to suppress role attribute #490

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f14e03
fix(Alert): honour explicit role={undefined} to suppress role attribute
jrlprost May 19, 2026
720ddd1
refactor(Alert): remove redundant role spread and refShouldSetRole ref
jrlprost May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Alert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,14 @@ export const Alert = memo(
closable: isClosableByUser = false,
isClosed: props_isClosed,
onClose,
role = "alert",
role: roleFromProps,
...rest
} = props;

// Honour explicit `role={undefined}` to opt out of the role attribute (RGAA 8.7).
// When role is omitted entirely, default to "alert" for screen reader announcements.
const role = "role" in props ? roleFromProps : ("alert" as const);

assert<Equals<keyof typeof rest, never>>();

const id = useAnalyticsId({
Expand Down Expand Up @@ -147,8 +151,8 @@ export const Alert = memo(
className
)}
style={style}
{...(refShouldSetRole.current && { "role": role })}
{...(role ? { "role": role } : {})}
{...(refShouldSetRole.current && role !== undefined && { "role": role })}

@revolunet revolunet May 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

à quoi sert cette ligne, c'est toujours écrasé en-dessous, non ?

{...(role !== undefined ? { "role": role } : {})}
ref={ref}
{...rest}
>
Expand Down