Profile Card UI Updated

[blyncnov]

Pull Request Preview

• Mobile View

• Large Screen

Screen

[d-e-v-esh]

Looks really good 🔥🔥
BTW you should remove the yarn.lock from staged changes before making a commit, otherwise it will overwrite the master yarn.lock file. The commit should contain only the files where you changed the code.

The quick solution will be that you can undo this commit, remove the yarn.lock file from the staged changes. then make back the commit and then do git push -f.

[d-e-v-esh]

Also I would suggest that you make multiple smaller commits as you are adding or removing things as opposed to one large commit. It will make it easier to look through and track back if needed in future.

[blyncnov]

Alright , will take note of those ..

Literally you mean, if I make changes in profile.js , then only profile.js should be in my commit ?

[blyncnov]

You can Review again

[d-e-v-esh]

Literally you mean, if I make changes in profile.js , then only profile.js should be in my commit ?

Yes! Exactly.

[d-e-v-esh]

The yarn.lock is still in this Pull Request. This number at the top right is inflated becasue of the changes in the yarn.lock. I think you will have to undo commit.

You will find lots of tutorials on YouTube on this topic that will help.

[padmajabhol]

Use styled components here instead of using h1/div tags.

[padmajabhol]

Please use styled components and convert the div and h1s. Also please delete the package -lock.json. We don't need to mix both npm and yarn packages. The UI looks good. Thanks a lot.

[blyncnov]

I will do that

[blyncnov]

Changes Made... I will wait back for your review.

Thanks

[d-e-v-esh]

@blyncnov You'll have to undo the commits, yarn lock is still in the Pull Request.

[blyncnov]

I thought I deleted that already.

[blyncnov]

@d-e-v-esh maybe you can show me how else if you are free ??

Initially I uncommitted and push the file, I can't find the yarn.lock in my branch of repo tho and in the PR, i see deleted

[d-e-v-esh]

Portfolio.-.Visual.Studio.Code.2022-10-09.14-09-04-1.mp4

@blyncnov I made a small video where I removed an image from a commit and re commited and pushed.

[blyncnov]

Great.. did that

[blyncnov]

Completed 👋

[d-e-v-esh]

@blyncnov Great! Can you please rename the commit from test removal to something more descriptive?

[blyncnov]

@d-e-v-esh Okay . Will do

[blyncnov]

Did that work @d-e-v-esh ??

[d-e-v-esh]

No, descriptive meaning something that tells more about that you added or removed from the codebase

[blyncnov]

@d-e-v-esh

I should do that via the commit message?

e.g

git commit -m "I improved user profile UI Card design bla bla bla "

Right ??

[d-e-v-esh]

@blyncnov Commit message has two parts, title and description. Look them up.

[blyncnov]

@d-e-v-esh please check

It's my first time with this really, and I am learning alot from you ..

Thanks

[d-e-v-esh]

@blyncnov You can yourself check under the commits section.

You see there are 3 commits, we want to have all the changes under one commit which is the latest one you made. I think you should undo all commits and re-commit it with the new commit message. And remove yarn lock from it. You don't have to wait for me to check. You can yourself check under the commits tab in the Pull Request.