Skip to content

Implement #3956 - initial coding hint support#3957

Open
clach04 wants to merge 2 commits into
codespell-project:mainfrom
clach04:issue_3956_coding
Open

Implement #3956 - initial coding hint support#3957
clach04 wants to merge 2 commits into
codespell-project:mainfrom
clach04:issue_3956_coding

Conversation

@clach04

@clach04 clach04 commented Jun 14, 2026

Copy link
Copy Markdown

No description provided.

@clach04

clach04 commented Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

I've opened this to generate discussion.

  1. What is expected to happen with badly declared / unknown encodings? Right now it dies ;-)
  2. byte.readlines seems to work OK, so rather than read a few hundred bytes and search for newlines, I'm relying on getlines(). I've deliberately not looking for wide encodings like UTF-16 (any variants) or UTF-32 (any variants)
  3. How many lines should be sniffed? Most editors seem to use 3 as the max - what I used for the initial implementation.

@clach04 clach04 mentioned this pull request Jun 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

@peternewman peternewman Awaiting requested review from peternewman peternewman is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@clach04