Repository navigation
Deduplicate formatter test fixtures to unblock PR linting - #33
Merged
Merged
Conversation
Co-authored-by: geoffreywiseman <49935+geoffreywiseman@users.noreply.github.com>
Co-authored-by: geoffreywiseman <49935+geoffreywiseman@users.noreply.github.com>
Co-authored-by: geoffreywiseman <49935+geoffreywiseman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for displaying totals in GitHub CLI extension
Add owner and grand totals to human and TSV usage output
Mar 6, 2026
Co-authored-by: geoffreywiseman <49935+geoffreywiseman@users.noreply.github.com>
Co-authored-by: geoffreywiseman <49935+geoffreywiseman@users.noreply.github.com>
Copilot
AI
changed the title
Add owner and grand totals to human and TSV usage output
Add aggregate totals to human and TSV output
Mar 7, 2026
Co-authored-by: geoffreywiseman <49935+geoffreywiseman@users.noreply.github.com>
Co-authored-by: geoffreywiseman <49935+geoffreywiseman@users.noreply.github.com>
Copilot
AI
changed the title
Add aggregate totals to human and TSV output
Keep aggregate totals in human output only and restore module metadata
Mar 7, 2026
geoffreywiseman
marked this pull request as ready for review
March 7, 2026 01:30
Co-authored-by: geoffreywiseman <49935+geoffreywiseman@users.noreply.github.com>
Co-authored-by: geoffreywiseman <49935+geoffreywiseman@users.noreply.github.com>
Copilot
AI
changed the title
Keep aggregate totals in human output only and restore module metadata
Keep aggregation in formatting, remove TSV totals, and restore module metadata
Mar 7, 2026
geoffreywiseman
approved these changes
Mar 7, 2026
Co-authored-by: geoffreywiseman <49935+geoffreywiseman@users.noreply.github.com>
Copilot
AI
changed the title
Keep aggregation in formatting, remove TSV totals, and restore module metadata
Deduplicate formatter test fixtures to unblock PR linting
Mar 7, 2026
geoffreywiseman
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR was failing on duplicated test setup in the formatter tests. This change extracts the shared multi-repository usage fixture so both formatter suites reuse the same data shape without repeating the same construction logic.
Problem
human_formatter_test.goandtsv_formatter_test.goeach inlined the same multi-repository fixturegolangci-lintflagged the overlap viaduplChange
format/formatter_test.goformat/human_formatter_test.goformat/tsv_formatter_test.goScope
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.