Make --skip omit anything with no usage in the period - #60
Merged
Merged
Conversation
--skip previously hid only repositories with no workflows, while still listing repositories whose workflows all showed zero and the zero-usage workflows inside busy repositories. That distinction dates from the old billing API, where zero billable minutes on a repository with workflows was a signal in itself. With usage computed from job durations, zero just means nothing ran, so --skip now drops zero-usage workflows first and then any repository left with none, on both the current-repo and explicit-target paths. The help text lists the flags, and the README's TSV example no longer shows zero rows under --skip. Closes #11 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The behavior is covered across code, documentation, and tests; remaining feedback is a minor documentation nit.
Pull request overview
Updates --skip to omit zero-usage workflows and repositories.
Changes:
- Applies shared filtering across execution paths.
- Updates help text and README examples.
- Adds tests for filtering behavior.
File summaries
| File | Summary |
|---|---|
README.md |
Documents the revised --skip behavior. |
main.go |
Applies filtering and updates CLI help. |
main_test.go |
Tests workflow and repository filtering. |
Review details
Suppressed comments (1)
main.go:164
- This changes the CLI contract, but the checked-in repository guidance still says
--skiponly omits repositories with no workflows (.github/copilot-instructions.md:51). Please update that statement as well; otherwise future contributors may rely on the old filtering behavior.
// skipUnused removes the workflows that had no usage in the period, and then the repositories left with no
// workflows, so that what remains is only where the usage went.
func skipUnused(repoFlowUsage client.RepoUsage) {
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--skippreviously hid only repositories with no workflows, while still listing repositories whose workflows all showed zero and the zero-usage workflows inside busy repositories. That distinction dates from the old billing API, where zero billable minutes on a repository with workflows was a signal in itself. With usage computed from job durations, zero just means nothing ran, so--skipnow drops zero-usage workflows first and then any repository left with none, on both the current-repo and explicit-target paths. The help text lists the flags, and the README's TSV example no longer shows zero rows under--skip.Closes #11