Skip to content

Bug: get_best() returns worst fitting distribution when method is set to the ks_statistic #73

Description

@andymd26

The logic for the identification of the best distribution fit in the get_best() function when the ks_statistic method is selected is backwards given the null hypothesis of the KS test. It looks like the get_best() function is returning the distribution with the minimum KS p-value. But the null hypothesis of the KS test is that the sample is distributed according to the reference distribution. And selecting the model with the minimum KS p-value means we're potentially picking the worst fitting distribution.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions