Re-work extension point test mocking - #738
Closed
cottsay wants to merge 1 commit into
Closed
Conversation
These brittle mocks stopped working right in Python 3.15. Rather than mock the functions, we can mock the data and let normal Python metadata discovery happen.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #738 +/- ##
==========================================
+ Coverage 87.09% 87.33% +0.24%
==========================================
Files 69 69
Lines 4130 4130
Branches 715 715
==========================================
+ Hits 3597 3607 +10
+ Misses 419 411 -8
+ Partials 114 112 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
This might be a good change to make long-term, but the bug that I'm trying to fix is actually a lot simpler, so I'm going to punt this for now. Closing in favor of #739. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These brittle mocks stopped working right in Python 3.15. Rather than mock the functions, we can mock the data and let normal Python metadata discovery happen.
Changes to the test functions are probably best viewed with whitespace modifications hidden due to the indentation changes in the test body: https://github.com/colcon/colcon-core/pull/738/changes?w=1