Skip to content

Enable and stabilize MetaDrive simulation tests in CI#38258

Open
HeetSoni26 wants to merge 2 commits into
commaai:masterfrom
HeetSoni26:ci/metadrive-simulation-test
Open

Enable and stabilize MetaDrive simulation tests in CI#38258
HeetSoni26 wants to merge 2 commits into
commaai:masterfrom
HeetSoni26:ci/metadrive-simulation-test

Conversation

@HeetSoni26

Copy link
Copy Markdown

Fixes #30693.

This addresses the timeouts that caused the \simulator_driving\ job to be disabled. The core issue is that 4-core GitHub Actions runners struggle with rendering + \ inygrad\ CPU inference concurrently.

This PR:

  1. Lowers the rate of the simulation bridge and MetaDrive physics strictly for CI (\CI=1), dropping the CPU pressure.
  2. Unblocks \loggerd\ and \encoderd\ during simulation ONLY when \SIM_LOGS=1\ is set, capturing \qlog\ and
    log\ for debugging without affecting local usage.
  3. Implements robust \os.killpg\ teardown in tests to avoid hanging zombies.
  4. Increases test timeouts and uploads artifacts of the generated logs.

Tested successfully by dropping the rate.

Fixes commaai#30693

- Conditional log generation with SIM_LOGS

- Explicit CPU yielding and rate reduction in CI

- Robust process group teardown and extended timeouts

- Upload artifacts for debugging
@github-actions

Copy link
Copy Markdown
Contributor

Process replay diff report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

✅ 0 changed, 66 passed, 0 errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run MetaDrive simulation test in GitHub Actions

1 participant