Enable and stabilize MetaDrive simulation tests in CI#38258
Open
HeetSoni26 wants to merge 2 commits into
Open
Conversation
Fixes commaai#30693 - Conditional log generation with SIM_LOGS - Explicit CPU yielding and rate reduction in CI - Robust process group teardown and extended timeouts - Upload artifacts for debugging
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30693.
This addresses the timeouts that caused the \simulator_driving\ job to be disabled. The core issue is that 4-core GitHub Actions runners struggle with rendering + \ inygrad\ CPU inference concurrently.
This PR:
log\ for debugging without affecting local usage.
Tested successfully by dropping the rate.