Skip to content

fix(fileflows): handle update API 401 and skip check on Node#14858

Open
michelroegl-brunner wants to merge 1 commit into
mainfrom
fix/fileflows-update-14622
Open

fix(fileflows): handle update API 401 and skip check on Node#14858
michelroegl-brunner wants to merge 1 commit into
mainfrom
fix/fileflows-update-14622

Conversation

@michelroegl-brunner
Copy link
Copy Markdown
Member

@michelroegl-brunner michelroegl-brunner commented Jun 1, 2026

✍️ Description

Fixes the FileFlows update command failing with curl: (22) / HTTP 401 when the server has security enabled.

  • Server: Checks api/status/update-available with curl -sSL (no -f) so catch_errors does not trap on 401. On 401, shows a clear error asking the user to disable security in FileFlows or use the web UI, then exits. Otherwise uses the existing UpdateAvailable logic.
  • Node: Skips the API check and always runs stop → backup → deploy → start (no server on port 19200).

🔗 Related Issue

Fixes #14622

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to script metadata (PocketBase/website data).
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Server installs check update-available without curl -f so 401 is handled with a clear message instead of aborting via catch_errors. Node installs skip the API and always run the zip update.

Fixes #14622

Co-authored-by: Cursor <cursoragent@cursor.com>
@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner June 1, 2026 13:55
@michelroegl-brunner michelroegl-brunner changed the title fix(fileflows): handle update API 401 and skip check on Node (fixes #14622) fix(fileflows): handle update API 401 and skip check on Node Jun 1, 2026
@github-actions github-actions Bot added bugfix update script A change that updates a script labels Jun 1, 2026
Comment thread ct/fileflows.sh
@MickLesk
Copy link
Copy Markdown
Member

MickLesk commented Jun 2, 2026

that should be a little bit more, i forgot to add my pr and to push the latest fixes

main...fix/fileflows-node-update

i remember following:

  1. Server = Serverside api call
  2. Node = need an update in the calls

When a node is installed, the script runs dotnet FileFlows.Node.dll without a --server address, which creates an empty config and exits with "Configuration not set" every time systemd tries to start it. Per the docs, the node needs --server [SERVER_ADDRESS] to configure which FileFlows server to connect to

i think you should deploy the script and test it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FileFlows] using update command gives an error

4 participants