Deallocation: Adds memory deallocation analysis functions#1052
Open
keremsahn wants to merge 1 commit into
Open
Deallocation: Adds memory deallocation analysis functions#1052keremsahn wants to merge 1 commit into
keremsahn wants to merge 1 commit into
Conversation
Contributor
Author
keremsahn
force-pushed
the
dealloc-detect
branch
2 times, most recently
from
db84730 to
9c871a2
Compare
keremsahn
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
==========================================
+ Coverage 86.62% 86.73% +0.10%
==========================================
Files 23 23
Lines 5946 6077 +131
==========================================
+ Hits 5151 5271 +120
- Misses 795 806 +11
🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| struct DeallocationTraverser : RecursiveASTVisitor<DeallocationTraverser> { | ||
| std::unordered_map<const clang::VarDecl*, const clang::ParmVarDecl*> aliasMap; | ||
| std::set<const clang::ParmVarDecl*> overwritenParms; | ||
| std::vector<DeallocType>& VPP; |
Contributor
There was a problem hiding this comment.
warning: no header providing "Cpp::DeallocType" is directly included [misc-include-cleaner]
nParms;
^| std::unordered_map<const clang::VarDecl*, const clang::ParmVarDecl*> aliasMap; | ||
| std::set<const clang::ParmVarDecl*> overwritenParms; | ||
| std::vector<DeallocType>& VPP; | ||
| DeallocationTraverser(std::vector<DeallocType>& v) : VPP(v) {} |
Contributor
There was a problem hiding this comment.
warning: member 'VPP' of type 'std::vector &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members]
>& VPP;
^|
|
||
| bool TraverseDecl(clang::Decl* D) { | ||
| if (D && llvm::isa<clang::TagDecl>(D)) | ||
| return true; |
Contributor
There was a problem hiding this comment.
warning: isa_and_nonnull<> is preferred over an explicit test for null followed by calling isa<> [llvm-prefer-isa-or-dyn-cast-in-conditionals]
Suggested change
| return true; | |
| l* D) { | |
| cl>(D))isa_and_nonnullm::isa<clang::TagDecl>(D) |
| updateVPP(PVR->getFunctionScopeIndex(), DeallocType::Free); | ||
| } | ||
|
|
||
| bool shouldVisitLambdaBody() const { return false; } |
Contributor
There was a problem hiding this comment.
warning: method 'shouldVisitLambdaBody' can be made static [readability-convert-member-functions-to-static]
Suggested change
| bool shouldVisitLambdaBody() const { return false; } | |
| );static |
| return; | ||
| } | ||
| DeallocationTraverser Traverser(valPerParam); | ||
| Traverser.TraverseStmt(const_cast<CompoundStmt*>(CmpStmt)); |
Contributor
There was a problem hiding this comment.
warning: do not use const_cast to remove const qualifier [cppcoreguidelines-pro-type-const-cast]
Param);
^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXME 's and some other cases will be handled after I open issues.