[cmake] Use ExternalProject to generate GTest sub-build config#1053
Merged
Conversation
Use declarative CMAKE_ARGS: ExternalProject generates the configure command itself and forwards the parent generator, platform, toolset and instance. Fixes the case where a parent configured with -A Win32 -Thost=x64 spawned sub-builds on the VS generator's default x64 platform, which tries to link x64 objects against the forwarded /machine:X86 linker flags and fail.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1053 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 23 23
Lines 5946 5946
=======================================
Hits 5151 5151
Misses 795 795 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use declarative
CMAKE_ARGS: ExternalProject generates the configure command itself and forwards the parent generator, platform and toolset. Fixes the case where a parent configured with-A Win32 -Thost=x64spawned sub-builds on the VS generator's default x64 platform, which tries to link x64 objects against the forwarded /machine:X86 linker flags and fail.Required by #1051