Revert "[ci] Add workflow for 32-bit MSVC (windows-2025 x86)"#1055
Merged
Conversation
This reverts commit eff0543.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
==========================================
- Coverage 86.65% 86.62% -0.03%
==========================================
Files 23 23
Lines 5948 5946 -2
==========================================
- Hits 5154 5151 -3
- Misses 794 795 +1
... and 1 file with indirect coverage changes
🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // Replacement that reads the object via `this`: layout is { vptr, int value } | ||
| // on every ABI we target, so the data member sits at sizeof(void*). | ||
| extern "C" int repl_read_value(void* self, int x) { | ||
| int v = *reinterpret_cast<int*>(static_cast<char*>(self) + sizeof(void*)); |
Contributor
There was a problem hiding this comment.
warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]
int v = *reinterpret_cast<int*>(static_cast<char*>(self) + sizeof(void*));
^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1051 as that branch was to test all Windows patches. I have open PRs for each patch, and will land them after testing with ROOT.