Skip to content

Perf/inner product fused kernel #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Praz314159 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Perf/inner product fused kernel #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f896fdb
Skip shrink_to_fit in per-round folds
Praz314159 Jul 2, 2026
5fcbab6
Delegate InnerProductProver::round to the fused kernel
Praz314159 Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/inner_product_sumcheck.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ pub fn fold<F: SumcheckField>(values: &mut Vec<F>, weight: F) {
scalar_mul(tail, F::ONE - weight);

values.truncate(half);
values.shrink_to_fit();
// Skip shrink_to_fit — realloc per round is pricier than the capacity
// we carry; the capacity frees once the Vec drops.
}

/// Two-pass fold-then-compute; reference version kept for testing.
Expand Down
4 changes: 2 additions & 2 deletions src/multilinear_sumcheck.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ pub fn fold<F: SumcheckField>(values: &mut Vec<F>, weight: F) {
))]
{
if crate::simd_sumcheck::dispatch::try_simd_reduce_msb(values, weight) {
values.shrink_to_fit();
return;
}
}
Expand Down Expand Up @@ -174,7 +173,8 @@ pub fn fold<F: SumcheckField>(values: &mut Vec<F>, weight: F) {
scalar_mul(tail, F::ONE - weight);

values.truncate(half);
values.shrink_to_fit();
// Skip shrink_to_fit — realloc per round is pricier than the capacity
// we carry; the capacity frees once the Vec drops.
}

/// Two-pass fold-then-compute. Reference only.
Expand Down
51 changes: 5 additions & 46 deletions src/provers/inner_product.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,56 +59,15 @@ where
}

fn round(&mut self, challenge: Option<F>) -> Vec<F> {
// Fold with previous challenge (if any).
if let Some(w) = challenge {
ip::fold(&mut self.a, w);
ip::fold(&mut self.b, w);
}

// EvalsInfty: emit [q(0), q(∞)] where
// q(0) = dot(a_lo, b_lo)
// q(∞) = [x²] q(x) = dot(a_hi − a_lo, b_hi − b_lo)
// = Σ (ah − al)·(bh − bl)
// The verifier derives q(1) = claim - q(0).
let n = self.a.len();
if n <= 1 {
let v = if n == 1 {
self.a[0] * self.b[0]
} else {
F::ZERO
};
return vec![v, F::ZERO];
}

let half = n.next_power_of_two() >> 1;
let (a_lo, a_hi) = self.a.split_at(half);
let (b_lo, b_hi) = self.b.split_at(half);

// a_lo may be longer than a_hi (non-pow2 input, implicit zero padding).
let paired = a_hi.len();
let a_lo_paired = &a_lo[..paired];
let b_lo_paired = &b_lo[..paired];
let a_lo_tail = &a_lo[paired..];
let b_lo_tail = &b_lo[paired..];

let mut q0 = F::ZERO;
let mut q_inf = F::ZERO;
for i in 0..paired {
let al = a_lo_paired[i];
let ah = a_hi[i];
let bl = b_lo_paired[i];
let bh = b_hi[i];
q0 += al * bl;
q_inf += (ah - al) * (bh - bl);
}

// Tail (hi implicitly zero): ah = bh = 0, so
// q(0) += al·bl
// q(∞) += (0 − al)·(0 − bl) = al·bl
let tail_dot: F = a_lo_tail.iter().zip(b_lo_tail).map(|(&a, &b)| a * b).sum();
q0 += tail_dot;
q_inf += tail_dot;

let (q0, q_inf) = if let Some(w) = challenge {
ip::fused_fold_and_compute_polynomial(&mut self.a, &mut self.b, w)
} else {
ip::compute_sumcheck_polynomial(&self.a, &self.b)
};
vec![q0, q_inf]
}

Expand Down