fix: detect and convert secrets in initContainers, not just containers - #56
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes secret detection and secret-name replacement for Kubernetes initContainers, ensuring secrets referenced only in initContainers are no longer silently ignored during secret processing/sealing workflows.
Changes:
- Update secret detection (
DetectSecrets) to scan bothcontainersandinitContainers. - Update manifest transformations (
ReplaceSecretName,ConvertEnvSecretToSealed,ConvertEnvFromSecret) to operate on bothcontainersandinitContainers. - Add an integration manifest and tests covering initContainer env-secret detection and conversion.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/secrets/secrets.go | Detect secrets and volume mount paths from both containers and initContainers. |
| pkg/manifest/manifest.go | Apply secret reference transformations across containers and initContainers. |
| integration_test/testdata/manifests/pod-with-initcontainer-secrets.yaml | New fixture manifest with a secret referenced only in an initContainer env var. |
| integration_test/secrets_test.go | Add integration coverage for initContainer env-secret conversion and detection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DetectSecrets, ConvertEnvSecretToSealed, ConvertEnvFromSecret, and ReplaceSecretName only iterated over podSpec["containers"], so secrets referenced exclusively in initContainers were silently ignored and no sealed secret file was generated. Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
bpradipt
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DetectSecrets, ConvertEnvSecretToSealed, ConvertEnvFromSecret, and ReplaceSecretName only iterated over podSpec["containers"], so secrets referenced exclusively in initContainers were silently ignored and no sealed secret file was generated.