Following up on #1104: the review called for missing-terminal-status coverage across all four gRPC and gRPC-Web operation kinds. I’m happy to take that on.
My read is that unary/client-streaming should fail without a successful payload, while server-streaming/half-duplex bidi should deliver the valid message, then fail. I’d expect CODE_INTERNAL, allowing CODE_UNKNOWN.
One question before I put up the PR: grpc-web 1.5.0 and 2.0.2 treat missing trailers as success for unary/server-streaming. Should those be narrow known failures, or should the adapter synthesize the error?
Following up on #1104: the review called for missing-terminal-status coverage across all four gRPC and gRPC-Web operation kinds. I’m happy to take that on.
My read is that unary/client-streaming should fail without a successful payload, while server-streaming/half-duplex bidi should deliver the valid message, then fail. I’d expect
CODE_INTERNAL, allowingCODE_UNKNOWN.One question before I put up the PR: grpc-web 1.5.0 and 2.0.2 treat missing trailers as success for unary/server-streaming. Should those be narrow known failures, or should the adapter synthesize the error?