Add gRPC and gRPC-Web coverage for missing terminal status - #1123
Open
EffortlessSteven wants to merge 3 commits into
Open
Add gRPC and gRPC-Web coverage for missing terminal status#1123EffortlessSteven wants to merge 3 commits into
EffortlessSteven wants to merge 3 commits into
Conversation
Signed-off-by: Steven Zimmerman, CPA <15812269+EffortlessSteven@users.noreply.github.com>
jhump
reviewed
Aug 3, 2026
jhump
left a comment
Member
There was a problem hiding this comment.
LGTM. Assuming CI checks out (which I assume it will), the only thing I'd want to tweak is the comment in the known-failing file for grpc-web.
Signed-off-by: Steven Zimmerman, CPA <15812269+EffortlessSteven@users.noreply.github.com>
jhump
enabled auto-merge (squash)
August 4, 2026 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The client suites did not cover the full gRPC and gRPC-Web operation matrix for a valid response message followed by EOF without terminal
grpc-status.Change: add unary, client-streaming, server-streaming, and half-duplex bidi cases for both protocols. Unary and client-streaming must fail without returning a payload; server-streaming and half-duplex bidi must deliver the valid payload before the terminal error. The browser adapter is unchanged; grpc-web's unary and server-streaming behavior is recorded as two narrow known failures.
Verification
make,make checkgenerate, andgit diff --checkclean in a Linux-native checkoutReview map
internal/app/connectconformance/testsuites/data/grpc_client_unexpected.yaml: the four native gRPC cases, terminating with no HTTP trailers.internal/app/connectconformance/testsuites/data/grpc_web_client_unexpected.yaml: the same operation matrix, omitting the in-body trailers frame.testing/grpcwebclient-known-failing.txt: records the official grpc-web divergence for unary and server-streaming, the only operation kinds the client advertises.Closes #1115.