fix: exclude oem/smc ikvm/memoryhealthcomp from dupl lint - #39
Merged
Conversation
The WithContext transformation adds identical boilerplate to these two already near-duplicate upstream files, pushing the pair over the dupl threshold. Exclude them in config rather than hand-editing transformed files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
joeyberkovitz
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Lint check on
mainis failing (run 31184342724) with 2duplfindings:oem/smc/ikvm.goandoem/smc/memoryhealthcomp.goare flagged as duplicates of each other.These two upstream files were already near-identical boilerplate; the WithContext transformation added ~12 identical lines to each, pushing the pair over the
duplthreshold of 200 tokens. Since mechanically transformed resource files shouldn't be hand-edited (//nolintcomments would be a conflict magnet on every upstream sync), this excludes the pair fromduplin.golangci.yaml— same pattern as the existinggocritic.importShadowaccommodation.Verification
golangci-lint run(v2.6.2, matching CI) over the full repo: 0 issuesgolangci-lint config verify(v2.6.2): passes🤖 Generated with Claude Code