[linalg.algs.blas1.iamax] Fix return type of vector_idx_abs_max#9140
Open
abhinavagarwal07 wants to merge 1 commit into
Open
[linalg.algs.blas1.iamax] Fix return type of vector_idx_abs_max#9140abhinavagarwal07 wants to merge 1 commit into
abhinavagarwal07 wants to merge 1 commit into
Conversation
The declarations use extents_type (a std::extents shape type), but the Returns clause specifies a scalar index of type size_type. Replace extents_type with size_type in [linalg.syn] and [linalg.algs.blas1.iamax].
Member
|
This fixes a misapplication of https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p1673r13.html#index-of-maximum-absolute-value-of-vector-elements-linalg.algs.blas1.iamax #6704 got the return type wrong. |
eisenwave
added
the
P1-Important
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The declarations of
vector_idx_abs_maxin[linalg.syn]and[linalg.algs.blas1.iamax]useextents_type(astd::extentsshape type) as the return type, but the Returns clause specifies a scalar index of typesize_type. Replaceextents_typewithsize_typein all four declaration sites.