Repository navigation
ci(release): push version branch via git CLI - #136
Merged
Merged
Conversation
changesets/action v2's default (push-with-git-cli: false) pushes version branch commits through the GitHub API via @changesets/ghcommit, which no-ops whenever the working tree is clean. Since this repo configures changesets to auto-commit the version bump (DCO-signed commit hook + identity from changeset-version-ci), the tree is clean after versioning and the action never moved the changeset-release/main branch - the version PR was metadata-updated but its branch kept the old tip. Switch to push-with-git-cli: true so the action force-pushes the already-committed DCO-signed version commit to the release branch. Signed-off-by: Ajay Jadhav <ajay@ayanworks.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Release workflow finished green, but the version PR's branch (
changeset-release/main) was never advanced — PR #103 got only its title/body updated.Root cause:
changesets/action@v2defaults topush-with-git-cli: false, pushing the version-branch commits through the GitHub API via@changesets/ghcommit, which no-ops whenever the working tree is clean. This repo's changesets config auto-commits the version bump (DCO-signed hook +github-actions[bot]identity fromchangeset-version-ci), so afterchangeset versionthe tree is clean and ghcommit creates nothing.Fix
Add
push-with-git-cli: true. The action then force-pushes the localHEAD— which already contains the committed DCO-signed version bump — tochangeset-release/main, moving the branch and updating the version PR.Keeps the DCO-signed
chore(release): new versioncommit authored bygithub-actions[bot](same pattern as the v2.1.1 release).