Skip to content

chore: Fix make lint - #332

Draft
yamaceay wants to merge 1 commit into
crossplane-contrib:mainfrom
yamaceay:better-lint
Draft

yamaceay wants to merge 1 commit into
crossplane-contrib:mainfrom
yamaceay:better-lint

Conversation

@yamaceay

Copy link
Copy Markdown
Contributor

Description of your changes

This PR fixes #331 by:

  1. implementing a platform-agnostic (= working on Linux and Mac) solution for parsing the GOLANGCI_VERSION correctly
  2. and modifying the .golangci.yml so that it excludes all directories starting with the prefix ../../go/pkg/mod.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Run either make lint or make reviewable test to reproduce or test the results.

Signed-off-by: Yamac Ay <yamac.ay@sap.com>
@yamaceay
yamaceay marked this pull request as draft September 11, 2025 14:19
@MisterMX MisterMX changed the title Fix Bugs in Make Lint chore: Fix make lint Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated Makefile (make reviewable test)

1 participant