Skip to content

fix: namespace repository scope - #379

Open
gravufo wants to merge 1 commit into
mainfrom
fix/namespace-repository-scope
Open

gravufo wants to merge 1 commit into
mainfrom
fix/namespace-repository-scope

Conversation

@gravufo

@gravufo gravufo commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Fixes #377: Cannot apply cluster scoped composed Repository resource for a namespaced composite resource.

Changes

  • Updated apis/namespace/repositories/v1alpha1/repository_types.go:

    • Changed kubebuilder resource marker from scope=Cluster to scope=Namespaced
    • This allows the Repository resource to be properly used in namespaced compositions
  • Regenerated package/crds/repositories.m.argocd.crossplane.io_repositories.yaml:

    • Updated the CRD spec scope from Cluster to Namespaced

Testing

Make generate was run and we can see the XRD is now namespace scoped.

@gravufo
gravufo force-pushed the fix/namespace-repository-scope branch from 792a7af to c0e6379 Compare September 11, 2026 03:22
@gravufo
gravufo requested a review from MisterMX September 11, 2026 03:23
@gravufo
gravufo force-pushed the fix/namespace-repository-scope branch from c0e6379 to e02173b Compare September 11, 2026 03:25
@gravufo gravufo changed the title Fix/namespace repository scope fix: namespace repository scope Sep 11, 2026
Comment thread .pr-metadata Outdated
@MisterMX

Copy link
Copy Markdown
Collaborator

Not sure if we should backport this change? Namespace scope is the correct one but there might be someone who relies on that resource being cluster scoped, though I think it is unlikely.

@gravufo
gravufo force-pushed the fix/namespace-repository-scope branch from e02173b to e26c518 Compare September 18, 2026 17:02
@gravufo

gravufo commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

Not sure if we should backport this change? Namespace scope is the correct one but there might be someone who relies on that resource being cluster scoped, though I think it is unlikely.

wasn't planning on backporting it, will be released in v0.17.0.
It technically is a breaking change, but we're still in v0.x so... :)

Change the Repository resource scope from Cluster to Namespaced and regenerate the corresponding CRD. Remove the placeholder commit used to trigger PR creation.

Signed-off-by: Christian Artin <gravufo@gmail.com>
@gravufo
gravufo force-pushed the fix/namespace-repository-scope branch from e26c518 to fbc22c6 Compare September 18, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot apply cluster scoped composed Repository resource for a namespaced composite resource.

2 participants