Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/release-logs/0.6.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@

**⚒️ Build:**

- Restructured build scripts into re-usable workflows and actions. ((See [PR #216](https://github.com/crud89/LiteFX/pull/216))
- Restructured build scripts into re-usable workflows and actions. (See [PR #216](https://github.com/crud89/LiteFX/pull/216))
- Remove all submodules from the repository (including vcpkg).
- Fix an issue that caused tests to timeout in CI builds. (See [PR #221](https://github.com/crud89/LiteFX/pull/221))

**📖 Documentation:**

Expand Down
6 changes: 2 additions & 4 deletions src/Backends/Vulkan/src/queue.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,7 @@ void VulkanQueue::waitFor(UInt64 fence) const
throw RuntimeException("Cannot wait for fence on a released device instance.");

UInt64 completedValue{ 0 };
//raiseIfFailed(::vkGetSemaphoreCounterValue(device->handle(), m_impl->m_timelineSemaphore, &completedValue), "Unable to query current queue timeline semaphore value.");
::vkGetSemaphoreCounterValue(device->handle(), m_impl->m_timelineSemaphore, &completedValue);
raiseIfFailed(::vkGetSemaphoreCounterValue(device->handle(), m_impl->m_timelineSemaphore, &completedValue), "Unable to query current queue timeline semaphore value.");

if (completedValue < fence)
{
Expand All @@ -316,8 +315,7 @@ void VulkanQueue::waitFor(UInt64 fence) const
.pValues = &fence
};

//raiseIfFailed(::vkWaitSemaphores(device->handle(), &waitInfo, std::numeric_limits<UInt64>::max()), "Unable to wait for queue timeline semaphore.");
::vkWaitSemaphores(device->handle(), &waitInfo, std::numeric_limits<UInt64>::max());
raiseIfFailed(::vkWaitSemaphores(device->handle(), &waitInfo, std::numeric_limits<UInt64>::max()), "Unable to wait for queue timeline semaphore.");
}

m_impl->releaseCommandBuffers(*this, fence);
Expand Down
3 changes: 2 additions & 1 deletion src/Logging/src/termination.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ void termination_sink::sink_it_(const spdlog::details::log_msg& msg)
if (msg.level >= m_minLevel)
{
std::println("{}\r\nTrace: {}", msg.payload, std::stacktrace::current());
::exit(m_status);
std::fflush(stdout);
std::quick_exit(m_status);
}
}

Expand Down
2 changes: 2 additions & 0 deletions src/Tests/Backends.Vk/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,8 @@ DEFINE_TEST("device_sets_up_vk_acceleration_structures" FOLDER "Tests/Backends/V
DEPENDENCIES LiteFX::AppModel LiteFX::Rendering LiteFX::Logging LiteFX::Vulkan
)

SET_TESTS_PROPERTIES(device_sets_up_vk_acceleration_structures PROPERTIES TIMEOUT 120)

DEFINE_TEST("shader_program_reflects_vk_render_pipeline_with_dynamic_descriptors" FOLDER "Tests/Backends/Vk" EXECUTABLE_NAME "vk_reflect_dynamic_descriptors_pipeline_test"
SOURCES "common.h" "reflect_dynamic_descriptors.cpp"
DEPENDENCIES LiteFX::AppModel LiteFX::Rendering LiteFX::Logging LiteFX::Vulkan
Expand Down
2 changes: 2 additions & 0 deletions src/Tests/Backends.Vk/setup_acceleration_structure.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,8 @@ LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)

int main(int /*argc*/, char* argv[])
{
std::setvbuf(stdout, nullptr, _IONBF, 0);

// Set the current path.
auto binaryDir = std::filesystem::path(argv[0]);
std::filesystem::current_path(binaryDir.remove_filename());
Expand Down