Fix cross-origin requests answering 500 instead of being denied - #638
Merged
bnolan merged 1 commit intoAug 22, 2026
Merged
Conversation
Handing the cors middleware an Error sends it to next(err), so every cross-origin request from a site outside the allowlist answers 500 for every route, static assets included. Denying the header instead lets the response through and leaves the browser to block it, which is what the allowlist was for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request carrying an
Originheader from outside the allowlist answers 500,on every route, static assets included.
The origin callback in
server/server.tshandscorsanErrorfor an originit does not allow. The middleware passes that to
next(err), so the requestfails rather than being answered without the header.
callback(null, false)isthe deny: the response goes out as normal and the browser blocks the read
itself, which is what the allowlist was for.
Same for
/animations/*.glband every JSON route, so a third-party page cannottell a blocked read from a broken server, and error tracking sees 500s that are
not.
Checked with prettier,
tsc --noEmit --project tsconfig.precommit.json(no newerrors) and
pnpm test(129 green). Happy to check the built branch againstwomp.world, which reads this API in production, before it ships.