Skip to content

try to use the google protobuf field mask#144

Merged
labkode merged 1 commit into
cs3org:mainfrom
butonic:addmountpoint
Oct 4, 2021
Merged

try to use the google protobuf field mask#144
labkode merged 1 commit into
cs3org:mainfrom
butonic:addmountpoint

Conversation

@butonic

@butonic butonic commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

API changes for cs3org/reva#2001 (comment)

blocked by cs3org/cs3apis-build#14

with the cs3apis-build PR I was able to build the protobuf and go with:

docker run -v /path/to/cs3apis:/root/cs3apis -v /path/to/cs3apis-build/cs3apis-build:/usr/local/bin/cs3apis-build cs3org/cs3apis cs3apis-build -build-proto
docker run -v /path/to/cs3apis:/root/cs3apis -v /path/to/cs3apis-build/cs3apis-build:/usr/local/bin/cs3apis-build cs3org/cs3apis cs3apis-build -build-go

See cs3org/go-cs3apis#44

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

use received share

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic

butonic commented Oct 1, 2021

Copy link
Copy Markdown
Contributor Author

@ishank011 ci is green, the changes caused by the API change are fully implemented in cs3org/reva#2121

@labkode

labkode commented Oct 4, 2021

Copy link
Copy Markdown
Member

@butonic looks good, let's give it a try

@labkode labkode merged commit b33d276 into cs3org:main Oct 4, 2021
@butonic butonic deleted the addmountpoint branch October 4, 2021 11:27
@butonic

butonic commented Oct 4, 2021

Copy link
Copy Markdown
Contributor Author

I'll update cs3org/reva#2121 to use the upstream go-cs3org repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants